Recursive chevrons are bananas #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@kivikakk Do you have a rough idea for when this PR will ship? Thanks again for all your work getting these issues patched up! |
|
@brentjo This is unfortunately still pending a direction from upstream, hence commonmark#218 still being open. I might just merge this now to protect ourselves in the meantime; stand by. |
kivikakk
force-pushed
the
kivikakk/recursive-chevrons-are-bananas
branch
from
0272b8f
to
37cd730
Compare
|
🙇 thanks @kivikakk |
martincizek
added a commit
to orchitech/cmark-gfm
that referenced
this pull request
Apr 10, 2020
…n sourcepos tests unfortunately removed with github#49.
martincizek
added a commit
to orchitech/cmark-gfm
that referenced
this pull request
May 4, 2021
…n sourcepos tests unfortunately removed with github#49.
martincizek
added a commit
to orchitech/cmark-gfm
that referenced
this pull request
May 4, 2021
…n sourcepos tests unfortunately removed with github#49.
martincizek
added a commit
to orchitech/cmark-gfm
that referenced
this pull request
May 4, 2021
…n sourcepos tests unfortunately removed with github#49.
talum
pushed a commit
that referenced
this pull request
Sep 14, 2021
* Add some pathological regression tests * Fix new pathological case * Cleanup. * Give it a second, for Travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some janky testing which isn't supported on Windows, but it gets the job done.
This is to fix commonmark#218 — we trip a (different) regression test currently.