Add comment justifying why we set cache: false

github · Feb 22, 2024 · e3a86ed · e3a86ed
1 parent 5d55901
commit e3a86ed
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 0 deletions.
diff --git a/.github/workflows/__go-tracing-autobuilder.yml b/.github/workflows/__go-tracing-autobuilder.yml
diff --git a/.github/workflows/__go-tracing-custom-build-steps.yml b/.github/workflows/__go-tracing-custom-build-steps.yml
diff --git a/.github/workflows/__go-tracing-legacy-workflow.yml b/.github/workflows/__go-tracing-legacy-workflow.yml
diff --git a/pr-checks/checks/go-tracing-autobuilder.yml b/pr-checks/checks/go-tracing-autobuilder.yml
@@ -7,6 +7,8 @@ steps:
   - uses: actions/setup-go@v5
     with:
       go-version: "~1.22.0"
+      # to avoid potentially misleading autobuilder results where we expect it to download
+      # dependencies successfully, but they actually come from a warm cache
       cache: false
   - uses: ./../action/init
     with:

diff --git a/pr-checks/checks/go-tracing-custom-build-steps.yml b/pr-checks/checks/go-tracing-custom-build-steps.yml
@@ -5,6 +5,8 @@ steps:
   - uses: actions/setup-go@v5
     with:
       go-version: "~1.22.0"
+      # to avoid potentially misleading autobuilder results where we expect it to download
+      # dependencies successfully, but they actually come from a warm cache
       cache: false
   - uses: ./../action/init
     with:

diff --git a/pr-checks/checks/go-tracing-legacy-workflow.yml b/pr-checks/checks/go-tracing-legacy-workflow.yml
@@ -7,6 +7,8 @@ steps:
   - uses: actions/setup-go@v5
     with:
       go-version: "~1.22.0"
+      # to avoid potentially misleading autobuilder results where we expect it to download
+      # dependencies successfully, but they actually come from a warm cache
       cache: false
   - uses: ./../action/init
     with: