Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autobuild: Update tests for C# on macOS #1149

Merged
merged 8 commits into from
Jul 27, 2022
Merged

autobuild: Update tests for C# on macOS #1149

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a326649
autobuild-action: Run autobuilders with $CODEQL_RUNNER set.
criemen Jul 21, 2022
ceec52c
Address review.
criemen Jul 21, 2022
2d2dfa3
Remove duplicate CI workflow
adityasharad Jul 25, 2022
dc1c51d
Actions: Fix failing Runner autobuild test on macOS
adityasharad Jul 25, 2022
58faf9d
Actions: Disable the CLR tracer in C# autobuild test
adityasharad Jul 25, 2022
b4ff463
Autobuild: Remove CODEQL_RUNNER workaround
adityasharad Jul 25, 2022
a2f4d66
Runner tests: Read CODEQL_RUNNER from the stored JSON
adityasharad Jul 25, 2022
caa2a0d
Runner tests: Attempt to source the tracer env, display the binary path
adityasharad Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions .github/workflows/__autobuild-action.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

64 changes: 64 additions & 0 deletions .github/workflows/__autobuild-macos-dotnet.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion lib/codeql.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/codeql.js.map
View file
Open in desktop

Large diffs are not rendered by default.

20 changes: 20 additions & 0 deletions pr-checks/checks/autobuild-action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: "autobuild-action"
description: "Tests that the C# autobuild action works"
versions: ["latest"]
steps:
- uses: ./../action/init
with:
languages: csharp
tools: ${{ steps.prepare-test.outputs.tools-url }}
- uses: ./../action/autobuild
adityasharad marked this conversation as resolved.
Show resolved Hide resolved
- uses: ./../action/analyze
env:
TEST_MODE: true
- name: Check database
shell: bash
run: |
cd "$RUNNER_TEMP/codeql_databases"
if [[ ! -d csharp ]]; then
echo "Did not find a C# database"
exit 1
fi
7 changes: 6 additions & 1 deletion src/codeql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,12 @@ async function getCodeQLForCmd(
"-Dmaven.wagon.http.pool=false",
].join(" ");

await runTool(autobuildCmd);
const runnerExe = process.env["CODEQL_RUNNER"];
adityasharad marked this conversation as resolved.
Show resolved Hide resolved
if (runnerExe) {
await runTool(runnerExe, [autobuildCmd]);
} else {
await runTool(autobuildCmd);
adityasharad marked this conversation as resolved.
Show resolved Hide resolved
}
},
async extractScannedLanguage(
databasePath: string,
Expand Down