Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clarify upload-sarify category uniqueness error message #1171

Merged
merged 1 commit into from
Aug 10, 2022
Merged

fix: clarify upload-sarify category uniqueness error message #1171

merged 1 commit into from
Aug 10, 2022

Conversation

crenshaw-dev
Copy link

I spent quite a while wondering why my category input didn't seem to be working. Eventually had to fix it by editing the sarif file. https://github.com/argoproj/argo-cd/pull/10171/files

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@crenshaw-dev crenshaw-dev requested a review from a team as a code owner August 5, 2022 15:00
@aeisenberg
Copy link
Contributor

Thanks for your PR. I think this change clarifies the error message.

@aeisenberg aeisenberg enabled auto-merge August 10, 2022 19:43
@aeisenberg aeisenberg merged commit a6d0901 into github:main Aug 10, 2022
@crenshaw-dev crenshaw-dev deleted the clarify-category-error-message branch August 10, 2022 20:35
This was referenced Aug 17, 2022
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crenshaw-dev @aeisenberg