Merge main into releases/v2 #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
When someone creates an invalid `queries` entry in the codeql config
file, like this:
```
queries:
- foo.ql
```
THe error message is confusing, looking like this:
```
Error: Cannot use 'in' operator to search for 'uses' in ql/ql/src
TypeError: Cannot use 'in' operator to search for 'uses' in ql/ql/src
at loadConfig (/home/runner/work/_actions/github/codeql-action/71a8b35ff4c80fcfcd05bc1cd932fe3c08f943ca/lib/config-utils.js:577:41)
```
With this change, the error message is more comprehensible:
`queries must be an array, with each entry having a 'uses' property`
This is no longer needed since `long` now includes its own types.
Mergeback fixes from v1 release
Mergeback v2.1.20 refs/heads/releases/v2 into main
TRAP Caching: Unset missing cache rather than setting to `undefined`
Handle other cases where the config is invalid.
Co-authored-by: Henry Mercer <henrymercer@github.com>
More readable error message for invalid `queries` block and invalid `query-filters` blocl
These were supplying CODEQL_EXTRACTOR_GO_BUILD_TRACING=true rather than CODEQL_EXTRACTOR_GO_BUILD_TRACING=on, therefore tracing wasn't being tested.
This is currently broken in CLI versions 2.10.3 and earlier.
It is enough to pass the checks now that we only use the runner for PR checks.
Fix Go tracing on Windows, and fix tests
Telemetry: Record DB creation time
…nalyzing the default branch.
…edule When running on a schedule, make a better guess about whether we're analyzing the default branch.
This was referenced Jun 24, 2023
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging 21bf308 into releases/v2
Conductor for this PR is @edoardopirovano
Contains the following pull requests:
undefined#1207 - TRAP Caching: Unset missing cache rather than setting toundefined(@edoardopirovano)queriesblock and invalidquery-filtersblock #1208 - More readable error message for invalidqueriesblock and invalidquery-filtersblocl (@aeisenberg)Please review the following: