Always log the full error #136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing
core.setFailed(e.message);is good as it highlights the error message to the user. It's unfortunately less useful to us for debugging because it doesn't include the stack trace. This PR amends every place to docore.setFailedto also log the full error to the console.I picked
console.logovercore.infoas that's what we currently do at the action entrypoints (e.g.) but we could change those to be
core.infoinstead. I'm pretty ambivalent.This could be another candidate for a custom CodeQL query for this repo, to catch places where we aren't logging the full error.
Here's what it looks like: https://github.com/dsp-testing/robertbrignull_no_language/runs/948487952?check_suite_focus=true
Merge / deployment checklist