Provide a better error message when languages are not recognised #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbrignull
force-pushed
the
invalid_language
branch
from
fb1afea to
6575405
Compare
Contributor
Author
|
Ah good, that fixes the tests. They passed for me locally the whole time which made it hard to debug. |
chrisgavin
approved these changes
Aug 10, 2020
Contributor
chrisgavin
left a comment
chrisgavin
left a comment
There was a problem hiding this comment.
Awesome. I tried it out with PHP as a language and indeed the error was much better.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the error message when the user specifies languages that doesn't exist. Currently it does something ugly like saying
A fatal error occurred: c-code-scanning.qls is not a well-known query suite.but this will make it much nicer. Also adds support for some well known aliases for languages that people might try. This feature is perhaps more debatable, but it might be nice to have since people are more likely to type "c" than to know that CodeQL uses "cpp" to refer to both.Also includes unit tests of the check for no languages, because I forgot to add that when doing that.
Here are some tests / demos:
Merge / deployment checklist