Remove legacy tracing #1618
Merged
Remove legacy tracing #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymercer
force-pushed
the
henrymercer/remove-legacy-tracing
branch
3 times, most recently
from
8658093 to
c409ef3
Compare
henrymercer
force-pushed
the
henrymercer/remove-legacy-tracing
branch
from
c409ef3 to
6ef3700
Compare
|
@adityasharad This is ready for a re-review. |
adityasharad
previously approved these changes
Mar 29, 2023
|
Fixed conficts. |
henrymercer
force-pushed
the
henrymercer/remove-legacy-tracing
branch
2 times, most recently
from
0a3fec8 to
d4eeb46
Compare
henrymercer
force-pushed
the
henrymercer/remove-legacy-tracing
branch
from
c226919 to
519e38e
Compare
henrymercer
force-pushed
the
henrymercer/remove-legacy-tracing
branch
from
519e38e to
2058418
Compare
adityasharad
approved these changes
Apr 19, 2023
|
Shall we bump the Action minor version when releasing this? |
|
Yes! Done in d13d683. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that GHES 3.4 has been deprecated, we no longer need to support CodeQL CLI 2.7.x. This lets us clear up a significant amount of tech debt, including removing support for legacy tracing. Databases are now always traced using DB clusters and the new tracer.
We'll hold off on merging this until the GHES 3.9 release of the Action is done: while the code paths for supported versions of the CLI shouldn't change, this PR touches quite a few places and waiting for GHES 3.10 minimises risk.
Merge / deployment checklist