Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable duplicate SARIF notification location workaround #1636

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Apr 6, 2023

We thought we'd fixed this in version 2.12.6 of the CLI, and our relevant test cases all passed. However now that 2.12.6 has fully rolled out, we've found another instance of this in the wild, so we need to re-enable the workaround in the Action.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner April 6, 2023 13:49
@henrymercer
Copy link
Contributor Author

Investigation will follow into what caused this problem to reoccur, but I'd like to re-enable the workaround as a fast fix.

@henrymercer henrymercer merged commit c28edf0 into main Apr 6, 2023
@henrymercer henrymercer deleted the henrymercer/re-enable-duplicate-sarif-workaround branch April 6, 2023 15:45
@github-actions github-actions bot mentioned this pull request Apr 6, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants