Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup-swift composite action for versions 5.8, 5.8.1 #1735

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

angelapwen
Copy link
Contributor

@angelapwen angelapwen commented Jun 20, 2023

Currently our PR checks are failing on main because the CodeQL Swift extractor version is 5.8.1, but the setup-swift action does not yet support Swift v.5.8.1. This change makes it so that we setup 5.8.0 instead.

Also, it adds the same check to Swift v5.8.0 as we originally had for v5.7.0 — we need to append the patch version explicitly, otherwise the setup-swift action defaults to the latest patch version.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@angelapwen angelapwen marked this pull request as ready for review June 20, 2023 12:57
@angelapwen angelapwen requested a review from a team as a code owner June 20, 2023 12:57
@angelapwen angelapwen merged commit 82dbde1 into github:main Jun 20, 2023
@angelapwen angelapwen deleted the setup-swift-update branch June 20, 2023 14:43
@github-actions github-actions bot mentioned this pull request Jun 21, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants