Only workaround invalid notifications for CodeQL CLI 2.13.0 and earlier #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeQL CLI 2.12.4, 2.12.5, 2.12.6, and 2.13.0 contained a bug where under some circumstances, CodeQL could produce an invalid SARIF output. The Action contains a workaround for this where it fixes up the SARIF to rectify this bug. Previously, we were applying this to all SARIF output that might contain diagnostics. This PR modifies this to only apply the workaround for CodeQL CLI 2.13.0 and earlier, which should speed up the Action a bit and reduce the chance of hitting the Node max string size.
Merge / deployment checklist