Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve downloading log message #1920

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Improve downloading log message #1920

merged 1 commit into from
Oct 5, 2023

Conversation

hoshinotsuyoshi
Copy link
Contributor

@hoshinotsuyoshi hoshinotsuyoshi commented Oct 4, 2023 •
edited by angelapwen
Loading

Regarding GitHub Actions log output, the dot was recognized as part of the URL.

dot

404error

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@hoshinotsuyoshi hoshinotsuyoshi marked this pull request as ready for review October 4, 2023 18:43
@hoshinotsuyoshi hoshinotsuyoshi requested a review from a team as a code owner October 4, 2023 18:43
angelapwen
angelapwen reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @hoshinotsuyoshi ✨ You will need to run npm run build in order to regenerate the relevant transpilation files.

@hoshinotsuyoshi
Improve downloading log message
6fe4546 
Regarding GitHub Actions log output, the dot was recognized as part of the URL.
@hoshinotsuyoshi hoshinotsuyoshi force-pushed the hoshinotsuyoshi/improve-log-url-in-setup-codeql branch from d9c08be to 6fe4546 Compare October 5, 2023 07:12
@hoshinotsuyoshi
Copy link
Contributor Author

@angelapwen Thank you! force-pushed 6fe4546 .

angelapwen
angelapwen approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I will turn auto-merge on for when the PR checks pass 🥳

@angelapwen angelapwen enabled auto-merge (squash) October 5, 2023 19:52
@aeisenberg
Copy link
Contributor

aeisenberg commented Oct 5, 2023 •
edited
Loading

The failing resolve-environment test recently had some changes. I wonder if something is wrong with the test.

@angelapwen
Copy link
Contributor

I think it should be unrelated as the failure is mv: cannot move 'node_modules' to '../action/node_modules': Permission denied in the prepare step. I'll re-run.

@angelapwen angelapwen merged commit 3f7850a into github:main Oct 5, 2023
360 checks passed
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Merged
6 tasks
@hoshinotsuyoshi hoshinotsuyoshi deleted the hoshinotsuyoshi/improve-log-url-in-setup-codeql branch October 10, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoshinotsuyoshi @aeisenberg @angelapwen