-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change to node20 for all actions #2006
Conversation
Pushed a commit to update the checked-in dependencies. Please mark the PR as ready for review to trigger PR checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes you made are good for bumping the node version of the actions. However, once we merge this, we can no longer release v2
of the action until we also update the release scripts to what we had before when we released v1
and v2
(now will be v2
and v3
). That's a dicey state to be in.
So, either we can recreate the release scripts and merge it first, or we do them at the same time. I can't remember how we did it last time.
45bedcc
to
8428059
Compare
This PR #1482 is the revert PR that removed the v1 release process. |
c684097
to
5b52b36
Compare
Pushed a commit to update the checked-in dependencies. Please mark the PR as ready for review to trigger PR checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's wait for the CodeQL 2.15.4 release to complete before merging this to reduce the risk of that release.
One potential safety check we could add is a PR check that fails if the release branch is v2
and the Node version of any Actions is Node 20. This could help make sure (a) we don't forget to switch the v2 branch back to running on node16
the first time we release it, and (b) any new Action we add to main
runs on node16
in the v2
branch.
Co-authored-by: Henry Mercer <henry.mercer@me.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions to the new PR check, looks good overall :)
Co-authored-by: Henry Mercer <henry.mercer@me.com>
NB – The introduction of a matrix for the Check JS job means that Once this PR is approved and ready to merge I will remove |
This PR upgrades all the actions to use
node20
, and bumps the major version tov3
.It also adds a new PR check to confirm the consistency of node versions across all actions, and ensure that we do not change this version in backport PRs to older releases.
Merge / deployment checklist