Workflow to split the bundle into components #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
robertbrignull
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
Workflow looks good to me so long as it's tested and works. The bit about finding the upload URL is unfortunately a bit hacky, but it seems fine.
As noted in person, we should move in the future to having the per-platform bundles be generated alongside the full bundle, but as the release is currently in progress that will have to wait until next time. I see no problem having this workflow here in the meantime until the codeql/bundle release process is updated.
Co-authored-by: Robert <robertbrignull@github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual workflow to split a codeql bundle into components.
It requires to know both the CLI version and the bundle tag. I tried to trigger this with a new release event, but that was too fragile and prone to errors. Also, right now, I think we cannot know the CLI version in a bundle without running
./codeql --version.Merge / deployment checklist