Skip to content

Fail more clearly if the file program is not installed on the runner #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 15, 2024
Merged

Fail more clearly if the file program is not installed on the runner #2234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8ea1a11
Produce a clearer error message when `file` is not installed
mbg Apr 11, 2024
1829b70
Emit diagnostic if `file` is not installed
mbg Apr 11, 2024
96f44cb
Add integration test for new diagnostic
mbg Apr 11, 2024
d4e7b0e
Check that the database exists before writing diagnostics to it
mbg Apr 11, 2024
4b0172d
Store diagnostics in memory until the database is available
mbg Apr 11, 2024
3901d12
Unify error messages in `getFileType`
mbg Apr 12, 2024
1ac88f3
Unconditionally report unwritten diagnostics at the end of the `init`…
mbg Apr 12, 2024
93f93fc
Include "Linux" in diagnostic name and message
mbg Apr 12, 2024
efc4746
Downgrade log levels for some messages to debug
mbg Apr 12, 2024
4fcf7a2
Add changelog entry
mbg Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 103 additions & 0 deletions .github/workflows/__go-indirect-tracing-workaround-no-file-program.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Note that the only difference between `v2` and `v3` of the CodeQL Action is the
We recommend removing any references to these from your workflows. For more information, see the release notes for CodeQL Action v3.23.0 and v2.23.0.
- Automatically overwrite an existing database if found on the filesystem. [#2229](https://github.com/github/codeql-action/pull/2229)
- Bump the minimum CodeQL bundle version to 2.12.6. [#2232](https://github.com/github/codeql-action/pull/2232)
- A more relevant log message and a diagnostic are now emitted when the `file` program is not installed on a Linux runner, but is required for Go tracing to succeed. [#2234](https://github.com/github/codeql-action/pull/2234)

## 3.24.10 - 05 Apr 2024

Expand Down
18 changes: 16 additions & 2 deletions lib/actions-util.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/actions-util.js.map
View file
Open in desktop

Large diffs are not rendered by default.

54 changes: 51 additions & 3 deletions lib/diagnostics.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/diagnostics.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions lib/init-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading