Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Checks: disable tests for Swift on Linux until CLI 2.17.4 #2299

Merged
merged 5 commits into from
May 20, 2024

Conversation

angelapwen
Copy link
Contributor

@angelapwen angelapwen commented May 17, 2024

With the new Linux runner image rollout and CLI versions <= 2.17.3, all PR checks with Swift are failing. This PR disables those tests to unblock CI for now. When CLI version 2.17.4 makes it to nightly-latest and latest, we will re-enable these tests.

The failing PR checks that were previously running on both ubuntu and macos have been updated to only run on macos for now. The failing PR checks that were previously running on only ubuntu have also been updated to only run on macos for now, so that we are at least covering these checks on one operating system.

Now that the debug artifacts check runs on macos instead of ubuntu, old versions of the CLI <2.15.1 are experiencing the known build tracer bug on ARM Macs, so those are disabled for now as well. We programmatically disabled those for the generated PR checks in #2261.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

Now that this check is running on MacOS, it runs into a known issue with the build tracer on ARM Macs that was fixed in CLI v2.15.1.
Go has been removed from the PATH in the most recent Mac runner images rollouts.
@angelapwen angelapwen marked this pull request as ready for review May 17, 2024 23:24
@angelapwen angelapwen requested a review from a team as a code owner May 17, 2024 23:24
@henrymercer henrymercer merged commit 3ee86e1 into main May 20, 2024
591 checks passed
@henrymercer henrymercer deleted the angelapwen/fix-pr-checks branch May 20, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants