Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve violations of import/no-extraneous-dependencies lint #238

Merged
merged 5 commits into from
Oct 5, 2020

Conversation

cbraynor
Copy link
Contributor

@cbraynor cbraynor commented Sep 29, 2020

These changes should remove the need to suppress the import/no-extraneous-dependencies lint in eslintrc.json.

We were relying on a dependency happening to also use this, so this makes it explicit and robust. We also switch to using the named export as the deep require has been deprecated since

Predicated on #237 to avoid merge conflicts (see diff just for these changes)

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (by which I mean the changes on top of #327)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants