Add support for dependency caching #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymercer
reviewed
Jul 23, 2024
| // with an empty string. | ||
| const globber = await makeGlobber(cacheConfig.hash); | ||
|
|
||
| if ((await globber.glob()).length === 0) { |
There was a problem hiding this comment.
Does this mean we list files twice (once here and once in cacheKey)? Might not be a performance problem in practice.
There was a problem hiding this comment.
Yes, it does. I looked at this before your review but, unfortunately, the hashFiles implementation in @action/glob isn't exposed in a way that we can just throw an existing array of paths at it, so we'd have to copy the implementation (or a variant of it, depending on how much we care about the intricacies of theirs).
mbg
force-pushed
the
mbg/add/dependency-caching
branch
from
04e457d to
c07c5b0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mbg
force-pushed
the
mbg/add/dependency-caching
branch
from
a2bb99e to
ff98043
Compare
mbg
force-pushed
the
mbg/add/dependency-caching
branch
from
c898cb9 to
ad48d53
Compare
henrymercer
previously approved these changes
Oct 28, 2024
mbg
force-pushed
the
mbg/add/dependency-caching
branch
from
ba64dbe to
bab8f1d
Compare
|
@henrymercer I have addressed your comments and rebased the PR branch on |
henrymercer
approved these changes
Oct 29, 2024
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work-in-progress to add support for dependency caching to the
initAction.Merge / deployment checklist