Bump artifacts dependencies #2461
Conversation
`@actions/artifacts@v1` is still not yet supported on GHES and we need to maintain backwards compatibility here. If we detect that a user is running on GHES, we fall back on the original `v1` import.
We can do this now that we have upgraded to `@actions/artifact@v2`; note that on GHES we are still using `@actions/artifact@v1`, but our PR checks are not running on GHES.
|
Hitting errors, which is interesting because the artifact paths are unique for each workflow run. It seems like a lot of others have reported this: actions/upload-artifact#478 — it looks like even if the artifact names are unique, the entire directory is marked as immutable and will fail with this conflict error in the newest version 🤔 I'll read through the thread to see if there's any consensus on the cleanest way to get around this. |
angelapwen
force-pushed
the
angelapwen/upgrade-artifacts
branch
from
af7457e
to
3c37ab4
Compare
|
Okay... it looks like uploading to a different artifact directory (name) each time will work, but this will break how some of our PR checks look for debug artifacts so I'll have to update those too. Also, I'm trying to think of any other consumers we have that might expect the debug directories to look a certain way 🤔 |
…acts at most once
angelapwen
force-pushed
the
angelapwen/upgrade-artifacts
branch
from
761813a
to
f249716
Compare
src/debug-artifacts.ts
Outdated
| retentionDays: 7, | ||
| }, | ||
| ); | ||
| if (ghVariant === GitHubVariant.GHES) { |
There was a problem hiding this comment.
Do you need to check for the GHES version here?
There was a problem hiding this comment.
I don't think so — no versions of GHES support the new artifacts dependencies yet 🤦
|
I split out a bunch of the refactoring into #2475 so that this PR can stick to bumping the dependencies. |
|
Closing in favor of #2482. |
Merge / deployment checklist