Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix making too many requests and triggering the rate limit. #253

Closed
wants to merge 1 commit into from
Closed

Fix making too many requests and triggering the rate limit. #253

wants to merge 1 commit into from

Conversation

chrisgavin
Copy link
Contributor

This hopefully fixes the fact we are no longer hitting the short circuiting logic due to githubUrl having a trailing slash, whereas util.GITHUB_DOTCOM_URL does not.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@chrisgavin
Copy link
Contributor Author

Fixed by 2466f2a.

@chrisgavin chrisgavin closed this Oct 5, 2020
@chrisgavin chrisgavin deleted the fix-rate-limit branch October 5, 2020 15:32
@woody-apple woody-apple mentioned this pull request Oct 6, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 25, 2023
Open
@aliscco aliscco mentioned this pull request Apr 26, 2023
Open
@Elsokary22 Elsokary22 mentioned this pull request Jul 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chrisgavin