Skip to content

Conversation

@mbg
Copy link
Member

@mbg mbg commented Jul 23, 2025

This will result in it being reported as a user error rather than a failure

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

…nfiguration error

This will result in it being reported as a user error rather than a failure
@mbg mbg requested review from Copilot and koesie10 July 23, 2025 11:49
@mbg mbg requested a review from a team as a code owner July 23, 2025 11:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates error handling to treat "multiple runs with the same category" as a configuration error rather than a processing failure. This change ensures that such errors are reported as user errors instead of system failures.

  • Adds a new expected configuration error message to the error classification logic
  • Updates both TypeScript source and compiled JavaScript to maintain consistency

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/upload-lib.ts Adds new error message to expectedConfigErrors array for proper classification
lib/upload-lib.js Generated JavaScript equivalent of the TypeScript changes

Copy link
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mbg mbg enabled auto-merge July 23, 2025 11:59
@mbg mbg merged commit 5a2327a into main Jul 23, 2025
282 checks passed
@mbg mbg deleted the mbg/combine-sarif-error branch July 23, 2025 12:02
@github-actions github-actions bot mentioned this pull request Jul 23, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants