-
Notifications
You must be signed in to change notification settings - Fork 403
Add analysis-kinds
input
#3061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analysis-kinds
input
#3061
Conversation
…uality-queries` For backwards compatibility. We should remove this once `quality-queries` is no longer in use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Replaces the synthetic value for `analysisKinds`
- `code-quality`: Analysis focused on code quality. This must be enabled in conjunction | ||
with `code-scanning`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of interest, where's this restriction coming from? We can address it in a follow up PR, but I think we want to be able to run code quality only analyses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this restriction will be lifted in a follow-up PR. It's just representative of the current state of the implementation as of this PR.
This PR follows up from #3055 and adds an
analysis-kinds
input to theinit
action. This is a required input, but defaults tocode-scanning
so that there's no change to existing workflows. The input is parsed and the resulting analysis kinds are stored in the configuration.The
isCodeQualityEnabled
function is updated to inspect that configuration, instead of thequality-queries
input.For backwards compatibility, we enable the
code-quality
analysis kind if there is an input toquality-queries
.Fundamentally, this PR shouldn't change the existing behaviour of the Action in any way.
Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist