Skip to content

Conversation

mbg
Copy link
Member

@mbg mbg commented Aug 27, 2025

This PR follows up from #3055 and adds an analysis-kinds input to the init action. This is a required input, but defaults to code-scanning so that there's no change to existing workflows. The input is parsed and the resulting analysis kinds are stored in the configuration.

The isCodeQualityEnabled function is updated to inspect that configuration, instead of the quality-queries input.

For backwards compatibility, we enable the code-quality analysis kind if there is an input to quality-queries.

Fundamentally, this PR shouldn't change the existing behaviour of the Action in any way.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg self-assigned this Aug 27, 2025
@mbg mbg requested a review from a team as a code owner August 27, 2025 17:26
@Copilot Copilot AI review requested due to automatic review settings August 27, 2025 17:26
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Comment on lines +54 to +55
- `code-quality`: Analysis focused on code quality. This must be enabled in conjunction
with `code-scanning`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of interest, where's this restriction coming from? We can address it in a follow up PR, but I think we want to be able to run code quality only analyses.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this restriction will be lifted in a follow-up PR. It's just representative of the current state of the implementation as of this PR.

henrymercer
henrymercer previously approved these changes Aug 28, 2025
Base automatically changed from mbg/cq/telemetry to main August 28, 2025 11:16
@mbg mbg dismissed henrymercer’s stale review August 28, 2025 11:16

The base branch was changed.

@mbg mbg requested a review from henrymercer August 28, 2025 12:44
@mbg mbg enabled auto-merge August 28, 2025 12:44
@mbg mbg disabled auto-merge August 28, 2025 12:48
@mbg mbg enabled auto-merge August 28, 2025 15:03
@mbg mbg merged commit a880e53 into main Aug 28, 2025
284 checks passed
@mbg mbg deleted the mbg/cq/analysis-kinds-input branch August 28, 2025 15:17
@github-actions github-actions bot mentioned this pull request Sep 1, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants