Skip to content

Conversation

mbg
Copy link
Member

@mbg mbg commented Sep 17, 2025

Fixes a bug with #3110, where we used url instead of browser_download_url.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@Copilot Copilot AI review requested due to automatic review settings September 17, 2025 15:56
@mbg mbg requested a review from a team as a code owner September 17, 2025 15:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where the code was using the url property instead of browser_download_url when fetching download URLs for proxy packages from GitHub release assets. The browser_download_url property provides the correct direct download link for release assets.

  • Changes the asset property reference from url to browser_download_url in the download URL retrieval logic
  • Updates corresponding logging message to reflect the correct property being used
  • Updates test mocks to use the correct property name for consistency

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/start-proxy.ts Updates getDownloadUrl function to use browser_download_url instead of url property
src/start-proxy.test.ts Updates test mock data to use browser_download_url property for consistency
lib/start-proxy-action.js Compiled JavaScript output reflecting the TypeScript changes

Comment on lines +258 to +262
{ name: "foo", browser_download_url: "other-url" },
{
name: startProxyExports.getProxyPackage(),
browser_download_url: "url-we-want",
},
Copy link

Copilot AI Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test mock data structure is inconsistent with the mockGetReleaseByTag function signature which expects Array<{ name: string; url?: string }>. The function should be updated to accept browser_download_url property or use a more flexible type to match the actual GitHub API response structure.

Copilot uses AI. Check for mistakes.

@mbg
Copy link
Member Author

mbg commented Sep 17, 2025

Closing in favour of #3120.

@mbg mbg closed this Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants