-
Notifications
You must be signed in to change notification settings - Fork 394
Merge main into releases/v3 #3172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Mergeback v3.30.5 refs/heads/releases/v3 into main
Note that this also fixes the format of the `sarif-ids` outputs to match what is documented
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Update vulnerable dependency brace-expansion
Add tests for `upload-sarif`
Since `fixCategory` is now part of `AnalysisConfig`, we don't have to remember to do it at the call site for `uploadSpecifiedFiles` or `uploadFiles` anymore.
…ths` that don't belong to an analysis kind
Add telemetry for dependency caching
…rkflow Remove `update-proxy-release` workflow
Add basic telemetry for `start-proxy` Action
Update default bundle to 2.23.2
Find, then filter, SARIF files for `upload-sarif` Action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR merges multiple changes from main into the releases/v3 branch, primarily focused on restructuring SARIF upload functionality and improving dependency caching telemetry. The changes prepare for v3.30.6 release by updating the CodeQL bundle version to 2.23.2.
Key Changes:
- Refactored SARIF upload functionality by extracting common logic into a new
upload-sarif.ts
module - Enhanced dependency caching with detailed telemetry reporting and usage tracking
- Updated default CodeQL bundle version from 2.23.1 to 2.23.2
Reviewed Changes
Copilot reviewed 37 out of 40 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/upload-sarif.ts | New module containing extracted SARIF upload logic |
src/upload-sarif-action.ts | Refactored to use new upload-sarif module |
src/dependency-caching.ts | Enhanced with detailed telemetry and cache usage tracking |
src/status-report.ts | Updated to include dependency caching telemetry |
src/defaults.json | Updated CodeQL bundle version to 2.23.2 |
package.json | Version bump to 3.30.6 |
lib/* | Generated JavaScript files reflecting TypeScript changes |
Files not reviewed (1)
- package-lock.json: Language not supported
Merging 10feb5d into
releases/v3
.Conductor for this PR is @nickrolfe.
Contains the following pull requests:
upload-sarif
#3166 (@mbg)upload-sarif
Action #3167 (@mbg)update-proxy-release
workflow #3170 (@mbg)start-proxy
Action #3171 (@mbg)Please do the following:
releases/v3
branch.Create a merge commit
is selected rather thanSquash and merge
orRebase and merge
.