Always skip database upload if AnalysisKind.CodeScanning is not enabled
#3221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Databases that are produced if
analysis-kinds: code-qualityis the only enabled analysis kind are initialised for a different set of queries than those that are initialised ifanalysis-kinds: code-scanningis enabled. This shouldn't really be a problem in itself, but the API endpoint for database uploads also doesn't currently accept uploads if Code Scanning is not enabled. That results in a warning in the CodeQL Action, rather than an outright failure, but both of these points combined mean it probably makes sense for us to skip attempting a database upload.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
analysis-kinds: code-quality).How did/will you validate this change?
.test.tsfiles).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist