Skip to content

Conversation

@mbg
Copy link
Member

@mbg mbg commented Oct 23, 2025

This test seems to frequently timeout on Windows, so this PR bumps the timeout a bit.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Tests only.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

N/A.

How will you know if something goes wrong after this change is released?

CI.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg requested a review from a team as a code owner October 23, 2025 12:40
Copilot AI review requested due to automatic review settings October 23, 2025 12:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the test timeout for the analyze-action-env test from the default value to 20 seconds to address frequent timeouts occurring on Windows.

Key Changes:

  • Added a 20-second timeout configuration to the "analyze action with RAM & threads from environment variables" test

@github-actions github-actions bot added the size/XS Should be very easy to review label Oct 23, 2025
henrymercer
henrymercer previously approved these changes Oct 23, 2025
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth bumping for src/analyze-action-input.test.ts too? That test is pretty similar on the face of it.

@mbg mbg merged commit 1c3c806 into main Oct 23, 2025
243 checks passed
@mbg mbg deleted the mbg/test/timeout branch October 23, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants