Skip to content

Conversation

@mbg
Copy link
Member

@mbg mbg commented Oct 30, 2025

Follow-up to #3251 which makes the checks in isEnablementError case-insensitive.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

  • Advanced setup - Impacts users who have custom workflows.
  • Default setup - Impacts users who use default setup.
  • Code Scanning - Impacts Code Scanning (i.e. analysis-kinds: code-scanning).
  • Code Quality - Impacts Code Quality (i.e. analysis-kinds: code-quality).
  • Third-party analyses - Impacts third-party analyses (i.e. upload-sarif).
  • GHES - Impacts GitHub Enterprise Server.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg requested a review from a team as a code owner October 30, 2025 11:38
Copilot AI review requested due to automatic review settings October 30, 2025 11:38
@github-actions github-actions bot added the size/S Should be easy to review label Oct 30, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the error message pattern matching in isEnablementError case-insensitive by adding the i flag to the regular expressions. This ensures that enablement errors are properly detected regardless of the casing used in error messages from the API.

Key Changes:

  • Added case-insensitive flag (i) to three regex patterns in isEnablementError function
  • Updated unit tests to verify case-insensitive matching with lowercase, uppercase, and original case transformations

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/api-client.ts Added i flag to regex patterns for case-insensitive enablement error detection
src/api-client.test.ts Refactored tests to verify case-insensitive matching using multiple case transformations
lib/upload-sarif-action.js Generated JavaScript with case-insensitive regex patterns
lib/upload-lib.js Generated JavaScript with case-insensitive regex patterns
lib/setup-codeql-action.js Generated JavaScript with case-insensitive regex patterns
lib/init-action.js Generated JavaScript with case-insensitive regex patterns
lib/init-action-post.js Generated JavaScript with case-insensitive regex patterns
lib/analyze-action.js Generated JavaScript with case-insensitive regex patterns

@mbg mbg enabled auto-merge October 30, 2025 11:45
@mbg mbg merged commit 9576b5c into main Oct 30, 2025
243 checks passed
@mbg mbg deleted the mbg/enablement-errors/case-insensitive branch October 30, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Should be easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants