Skip to content

Fix CI jobs that broke as a result of windows-latest being upgraded to Windows Server 2022 #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Fix CI jobs that broke as a result of windows-latest being upgraded to Windows Server 2022 #917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8047e5
Use `windows-2019` for CI jobs involving build tracing
henrymercer Feb 8, 2022
8dd2b9a
Fix typo in Python package installation CI job
henrymercer Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/__analyze-ref-input.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions .github/workflows/__go-custom-queries.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions .github/workflows/__go-custom-tracing.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions .github/workflows/__remote-config.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions .github/workflows/__upload-ref-sha-input.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions .github/workflows/pr-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,9 @@ jobs:
runner-analyze-csharp-windows:
name: Runner windows C# analyze
needs: [check-js, check-node-modules]
runs-on: windows-latest
# Build tracing currently does not support Windows 2022, so use `windows-2019` instead of
# `windows-latest`.
runs-on: windows-2019

steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -301,7 +303,9 @@ jobs:
runner-analyze-csharp-autobuild-windows:
name: Runner windows autobuild C# analyze
needs: [check-js, check-node-modules]
runs-on: windows-latest
# Build tracing currently does not support Windows 2022, so use `windows-2019` instead of
# `windows-latest`.
runs-on: windows-2019

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python-deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ jobs:

- uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
python-version: ${{ matrix.python_version }}

- name: Initialize CodeQL
uses: ./init
Expand Down
3 changes: 3 additions & 0 deletions pr-checks/checks/analyze-ref-input.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: "Analyze: 'ref' and 'sha' from inputs"
description: "Checks that specifying 'ref' and 'sha' as inputs works"
# Build tracing currently does not support Windows 2022, so use `windows-2019` instead of
# `windows-latest`.
os: [ubuntu-latest, macos-latest, windows-2019]
steps:
- uses: ./../action/init
with:
Expand Down
3 changes: 3 additions & 0 deletions pr-checks/checks/go-custom-queries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: "Go: Custom queries"
description: "Checks that Go works in conjunction with a config file specifying custom queries"
# Build tracing currently does not support Windows 2022, so use `windows-2019` instead of
# `windows-latest`.
os: [ubuntu-latest, macos-latest, windows-2019]
steps:
- uses: actions/setup-go@v2
with:
Expand Down
3 changes: 3 additions & 0 deletions pr-checks/checks/go-custom-tracing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: "Go: Custom tracing"
description: "Checks that Go tracing works"
# Build tracing currently does not support Windows 2022, so use `windows-2019` instead of
# `windows-latest`.
os: [ubuntu-latest, macos-latest, windows-2019]
env:
CODEQL_EXTRACTOR_GO_BUILD_TRACING: "true"
steps:
Expand Down
3 changes: 3 additions & 0 deletions pr-checks/checks/remote-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: "Remote config file"
description: "Checks that specifying packages using only a config file works"
# Build tracing currently does not support Windows 2022, so use `windows-2019` instead of
# `windows-latest`.
os: [ubuntu-latest, macos-latest, windows-2019]
steps:
- uses: ./../action/init
with:
Expand Down
3 changes: 3 additions & 0 deletions pr-checks/checks/upload-ref-sha-input.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: "Upload-sarif: 'ref' and 'sha' from inputs"
description: "Checks that specifying 'ref' and 'sha' as inputs works"
# Build tracing currently does not support Windows 2022, so use `windows-2019` instead of
# `windows-latest`.
os: [ubuntu-latest, macos-latest, windows-2019]
steps:
- uses: ./../action/init
with:
Expand Down