Don't download packs when it isn't needed #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardopirovano
force-pushed
the
edoardo/no-download-pack
branch
from
4302055 to
85cfdb2
Compare
henrymercer
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're using a CLI version that's new enough to do the parsing of config files itself, then it will also have downloaded any custom packs during
database initas needed. Runningpack downloadagain is redundant, and indeed in some cases can cause issues (for instance, QL4QL uses a local pack sopack downloadfails even though all the other commands happily find it on the search path).Merge / deployment checklist