Package: Side effects3 #272

rvermeulen · 2023-03-24T23:54:42Z

Description

Queries for package Side Effects 3

Change request type

Release or process automation (GitHub workflows, internal scripts)
Internal documentation
External documentation
Query files (.ql, .qll, .qls or unit tests)
External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

No rules added
Queries have been added for the following rules:
- rule number here
Queries have been modified for the following rules:
- rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

Yes
No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

Reviewer

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

github-actions · 2023-03-24T23:54:58Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-24T23:56:19Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_DIFFERENCE      : --- expected
                       +++ actual
                       @@ -1,5 +1,4 @@
                       -| test.c:6:12:6:18 | ... + ... | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:6:12:6:13 | l1 | side effect | test.c:6:12:6:13 | l1 | l1 | test.c:6:17:6:18 | l1 | side effect | test.c:6:17:6:18 | l1 | l1 |
                       -| test.c:7:12:7:18 | ... + ... | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:7:12:7:13 | l1 | side effect | test.c:7:12:7:13 | l1 | l1 | test.c:7:17:7:18 | l2 | side effect | test.c:7:17:7:18 | l2 | l2 |
                       -| test.c:17:3:17:21 | ... = ... | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:17:8:17:9 | l1 | side effect | test.c:17:8:17:9 | l1 | l1 | test.c:17:13:17:14 | l1 | side effect | test.c:17:13:17:14 | l1 | l1 |
                       -| test.c:19:3:19:5 | call to foo | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:19:7:19:8 | l1 | side effect | test.c:19:7:19:8 | l1 | l1 | test.c:19:11:19:12 | l2 | side effect | test.c:19:11:19:12 | l2 | l2 |
                       -| test.c:25:3:25:5 | call to foo | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:25:7:25:10 | ... ++ | side effect | test.c:25:7:25:8 | l8 | l8 | test.c:25:13:25:16 | ... ++ | side effect | test.c:25:13:25:14 | l9 | l9 |
                       +ERROR: Could not resolve module SideEffects3 (/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/src/codingstandards/cpp/exclusions/c/RuleMetadata.qll:49,8-20)
                       +ERROR: Could not resolve module SideEffects3Package (/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/misra/src/rules/RULE-13-2/UnsequencedSideEffects.ql:39,28-47)
                       +ERROR: Could not resolve predicate isSideEffects3QueryMetadata/4 (/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/src/codingstandards/cpp/exclusions/c/RuleMetadata.qll:153,3-30)
                       +ERROR: Could not resolve type SideEffects3Query (/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/src/codingstandards/cpp/exclusions/c/RuleMetadata.qll:101,29-46)
                       [1/1 comp 5.2s] FAILED(COMPILATION) /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/misra/test/rules/RULE-13-2/UnsequencedSideEffects.qlref
                       
TEST_PASS            : False
RULE                 : RULE-13-2
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
QUERY                : UnsequencedSideEffects
PACKAGE              : SideEffects3

github-actions · 2023-03-24T23:57:29Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-24T23:57:42Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-24T23:58:19Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_DIFFERENCE      : --- expected
                       +++ actual
                       @@ -1,5 +1,4 @@
                       -| test.c:6:12:6:18 | ... + ... | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:6:12:6:13 | l1 | side effect | test.c:6:12:6:13 | l1 | l1 | test.c:6:17:6:18 | l1 | side effect | test.c:6:17:6:18 | l1 | l1 |
                       -| test.c:7:12:7:18 | ... + ... | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:7:12:7:13 | l1 | side effect | test.c:7:12:7:13 | l1 | l1 | test.c:7:17:7:18 | l2 | side effect | test.c:7:17:7:18 | l2 | l2 |
                       -| test.c:17:3:17:21 | ... = ... | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:17:8:17:9 | l1 | side effect | test.c:17:8:17:9 | l1 | l1 | test.c:17:13:17:14 | l1 | side effect | test.c:17:13:17:14 | l1 | l1 |
                       -| test.c:19:3:19:5 | call to foo | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:19:7:19:8 | l1 | side effect | test.c:19:7:19:8 | l1 | l1 | test.c:19:11:19:12 | l2 | side effect | test.c:19:11:19:12 | l2 | l2 |
                       -| test.c:25:3:25:5 | call to foo | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:25:7:25:10 | ... ++ | side effect | test.c:25:7:25:8 | l8 | l8 | test.c:25:13:25:16 | ... ++ | side effect | test.c:25:13:25:14 | l9 | l9 |
                       +ERROR: Could not resolve module SideEffects3 (/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/src/codingstandards/cpp/exclusions/c/RuleMetadata.qll:49,8-20)
                       +ERROR: Could not resolve module SideEffects3Package (/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/misra/src/rules/RULE-13-2/UnsequencedSideEffects.ql:38,28-47)
                       +ERROR: Could not resolve predicate isSideEffects3QueryMetadata/4 (/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/src/codingstandards/cpp/exclusions/c/RuleMetadata.qll:153,3-30)
                       +ERROR: Could not resolve type SideEffects3Query (/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/src/codingstandards/cpp/exclusions/c/RuleMetadata.qll:101,29-46)
                       [1/1 comp 4.8s] FAILED(COMPILATION) /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/misra/test/rules/RULE-13-2/UnsequencedSideEffects.qlref
                       
RULE                 : RULE-13-2
TEST_PASS            : False
COMPILE_ERROR_OUTPUT : 
QUERY                : UnsequencedSideEffects
SUITE                : MISRA-C-2012
COMPILE_PASS         : True
PACKAGE              : SideEffects3

jsinglet · 2023-03-24T23:58:21Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-24T23:58:30Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-24T23:58:37Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-24T23:58:48Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


QUERY                : UnsequencedSideEffects
SUITE                : MISRA-C-2012
PACKAGE              : SideEffects3
RULE                 : RULE-13-2
TEST_DIFFERENCE      : --- expected
                       +++ actual
                       @@ -1,5 +1,4 @@
                       -| test.c:6:12:6:18 | ... + ... | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:6:12:6:13 | l1 | side effect | test.c:6:12:6:13 | l1 | l1 | test.c:6:17:6:18 | l1 | side effect | test.c:6:17:6:18 | l1 | l1 |
                       -| test.c:7:12:7:18 | ... + ... | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:7:12:7:13 | l1 | side effect | test.c:7:12:7:13 | l1 | l1 | test.c:7:17:7:18 | l2 | side effect | test.c:7:17:7:18 | l2 | l2 |
                       -| test.c:17:3:17:21 | ... = ... | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:17:8:17:9 | l1 | side effect | test.c:17:8:17:9 | l1 | l1 | test.c:17:13:17:14 | l1 | side effect | test.c:17:13:17:14 | l1 | l1 |
                       -| test.c:19:3:19:5 | call to foo | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:19:7:19:8 | l1 | side effect | test.c:19:7:19:8 | l1 | l1 | test.c:19:11:19:12 | l2 | side effect | test.c:19:11:19:12 | l2 | l2 |
                       -| test.c:25:3:25:5 | call to foo | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:25:7:25:10 | ... ++ | side effect | test.c:25:7:25:8 | l8 | l8 | test.c:25:13:25:16 | ... ++ | side effect | test.c:25:13:25:14 | l9 | l9 |
                       +ERROR: Could not resolve module SideEffects3 (/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/src/codingstandards/cpp/exclusions/c/RuleMetadata.qll:49,8-20)
                       +ERROR: Could not resolve module SideEffects3Package (/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/misra/src/rules/RULE-13-2/UnsequencedSideEffects.ql:38,28-47)
                       +ERROR: Could not resolve predicate isSideEffects3QueryMetadata/4 (/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/src/codingstandards/cpp/exclusions/c/RuleMetadata.qll:153,3-30)
                       +ERROR: Could not resolve type SideEffects3Query (/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/src/codingstandards/cpp/exclusions/c/RuleMetadata.qll:101,29-46)
                       [1/1 comp 4.6s] FAILED(COMPILATION) /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/misra/test/rules/RULE-13-2/UnsequencedSideEffects.qlref
                       
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_PASS            : False

jsinglet · 2023-03-24T23:58:50Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_PASS         : True
TEST_DIFFERENCE      : --- expected
                       +++ actual
                       @@ -1,5 +1,4 @@
                       -| test.c:6:12:6:18 | ... + ... | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:6:12:6:13 | l1 | side effect | test.c:6:12:6:13 | l1 | l1 | test.c:6:17:6:18 | l1 | side effect | test.c:6:17:6:18 | l1 | l1 |
                       -| test.c:7:12:7:18 | ... + ... | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:7:12:7:13 | l1 | side effect | test.c:7:12:7:13 | l1 | l1 | test.c:7:17:7:18 | l2 | side effect | test.c:7:17:7:18 | l2 | l2 |
                       -| test.c:17:3:17:21 | ... = ... | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:17:8:17:9 | l1 | side effect | test.c:17:8:17:9 | l1 | l1 | test.c:17:13:17:14 | l1 | side effect | test.c:17:13:17:14 | l1 | l1 |
                       -| test.c:19:3:19:5 | call to foo | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:19:7:19:8 | l1 | side effect | test.c:19:7:19:8 | l1 | l1 | test.c:19:11:19:12 | l2 | side effect | test.c:19:11:19:12 | l2 | l2 |
                       -| test.c:25:3:25:5 | call to foo | The expression contains unsequenced $@ to $@ and $@ to $@. | test.c:25:7:25:10 | ... ++ | side effect | test.c:25:7:25:8 | l8 | l8 | test.c:25:13:25:16 | ... ++ | side effect | test.c:25:13:25:14 | l9 | l9 |
                       +ERROR: Could not resolve module SideEffects3 (/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/src/codingstandards/cpp/exclusions/c/RuleMetadata.qll:49,8-20)
                       +ERROR: Could not resolve module SideEffects3Package (/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/misra/src/rules/RULE-13-2/UnsequencedSideEffects.ql:38,28-47)
                       +ERROR: Could not resolve predicate isSideEffects3QueryMetadata/4 (/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/src/codingstandards/cpp/exclusions/c/RuleMetadata.qll:153,3-30)
                       +ERROR: Could not resolve type SideEffects3Query (/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/common/src/codingstandards/cpp/exclusions/c/RuleMetadata.qll:101,29-46)
                       [1/1 comp 4.8s] FAILED(COMPILATION) /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/misra/test/rules/RULE-13-2/UnsequencedSideEffects.qlref
                       
QUERY                : UnsequencedSideEffects
RULE                 : RULE-13-2
COMPILE_ERROR_OUTPUT : 
PACKAGE              : SideEffects3
SUITE                : MISRA-C-2012
TEST_PASS            : False

jsinglet · 2023-03-24T23:58:59Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-24T23:59:03Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-24T23:59:07Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-24T23:59:11Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

jsinglet · 2023-03-25T00:00:18Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-25T00:00:30Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

github-actions · 2023-03-25T03:42:45Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-25T03:44:54Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
QUERY                : UnsequencedSideEffects
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
RULE                 : RULE-13-2
COMPILE_PASS         : True
PACKAGE              : SideEffects3

jsinglet · 2023-03-25T03:45:12Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-25T03:45:54Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-25T03:46:06Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-25T03:46:09Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-25T03:46:38Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


PACKAGE              : SideEffects3
TEST_DIFFERENCE      : 
QUERY                : UnsequencedSideEffects
TEST_PASS            : True
SUITE                : MISRA-C-2012
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-13-2

jsinglet · 2023-03-25T03:46:52Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

github-actions · 2023-03-25T20:02:45Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-25T20:04:29Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-25T20:06:12Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-25T20:06:15Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-25T20:06:39Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_DIFFERENCE      : 
TEST_PASS            : True
QUERY                : UnsequencedSideEffects
PACKAGE              : SideEffects3
SUITE                : MISRA-C-2012
RULE                 : RULE-13-2
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True

jsinglet · 2023-03-25T20:06:43Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


RULE                 : RULE-13-2
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
TEST_PASS            : True
QUERY                : UnsequencedSideEffects
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
PACKAGE              : SideEffects3

jsinglet · 2023-03-25T20:45:55Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

- Only consider unsequenced side effects to the same objects, unless - the two unsequenced side effects target two different volatile objects. - Don't allow unsequenced modification and reading of the same object, unless the reading is part of establishing the value of the modification.

knewbury01

@rvermeulen looking pretty good, just some suggestions here and there! lmk when to look for another cycle!

c/misra/src/rules/RULE-13-2/UnsequencedSideEffects.ql

c/misra/test/rules/RULE-13-2/test.c

c/common/src/codingstandards/c/Expr.qll

lcartey

I am approving this PR, but note that (a) the metadata needed regenerating and (b) it needed some performance improvements. I've completed that in a separate PR which includes this PR:
#282
And I think we should merge that instead of this PR.

lcartey · 2023-03-30T15:10:32Z

Closing as #282 was merged.

rvermeulen marked this pull request as ready for review March 28, 2023 04:44

rvermeulen requested review from mbaluda and jsinglet March 28, 2023 04:44

rvermeulen added 12 commits March 27, 2023 21:57

Add SidePackage3 rule description and metadata

f2ce331

Change the definition of a full expr to match the standard

ee8db1d

Add full declarators case to ordering module

25cee4f

Consider children expression when determining ordering

3e88808

Address typos

19bebdd

Remove unimplemented queries for RULE-13-2 from package.

86540f5

Add query for RULE 13-2

96317b6

Correct comments

3e94fd7

Attemp to optimize query

f0ee5b1

Add comments to explain steps

84b1ad8

Provide more useful predicate names

962a640

rvermeulen force-pushed the rvermeulen/side-effects3 branch from 49ce948 to 9deadab Compare March 28, 2023 04:58

Remove PRE31-C from side effects 3

a3d046f

mbaluda requested a review from knewbury01 March 28, 2023 08:45

knewbury01 reviewed Mar 28, 2023

View reviewed changes

rvermeulen added 4 commits March 29, 2023 15:50

Address incorrect alert specification

bef7b9e

Add support for MISRA example case

dc02657

Remove PRE31-C from side effects 3

ca80465

Update FullExpr.expected

f0d8026

rvermeulen requested a review from knewbury01 March 30, 2023 00:01

Merge branch 'main' into rvermeulen/side-effects3

693df26

lcartey mentioned this pull request Mar 30, 2023

Package SideEffects3 with added performance fixes #282

Merged

30 tasks

lcartey approved these changes Mar 30, 2023

View reviewed changes

lcartey closed this Mar 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Package: Side effects3 #272

Package: Side effects3 #272

rvermeulen commented Mar 24, 2023 •

edited

Loading

github-actions bot commented Mar 24, 2023

jsinglet commented Mar 24, 2023

github-actions bot commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

github-actions bot commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

github-actions bot commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

knewbury01 left a comment

lcartey left a comment

lcartey commented Mar 30, 2023

Package: Side effects3 #272

Package: Side effects3 #272

Conversation

rvermeulen commented Mar 24, 2023 • edited Loading

Description

Change request type

Rules with added or modified queries

Release change checklist

Query development review checklist

Author

Reviewer

github-actions bot commented Mar 24, 2023

jsinglet commented Mar 24, 2023

github-actions bot commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 24, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

github-actions bot commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

github-actions bot commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

jsinglet commented Mar 25, 2023

knewbury01 left a comment

Choose a reason for hiding this comment

lcartey left a comment

Choose a reason for hiding this comment

lcartey commented Mar 30, 2023

rvermeulen commented Mar 24, 2023 •

edited

Loading