-
Notifications
You must be signed in to change notification settings - Fork 64
Address "Updated expected results" C++ compiler compatibility issues #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move "rand" definition to the global namespace and import into std with "using", to better reflect "real" compilers.
Our compiler testing only uses a single compiler and cannot replicate execution boundaries, so we simply ignore this test by expecting no results.
Move global locale definitions to locale.h, and import them into std with "using" to better reflect real compilers.
Our compiler testing only uses a single compiler and cannot replicate execution boundaries, so we simply ignore this test by expecting no results.
Macro parameter names vary by compiler.
Better reflect how real compilers implement csignal.
Modify cstdio to more closely match real compilers.
The source location is different between compiler testing and qltest, leading to spurious differences. This simplifies the query, reporting only the base name of the file but still reporting the link.
mbaluda
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All issues fixed 🚢
🤖 Beep Boop! qcc/cpp/aarch64le Matrix Testing for this PR has been completed. See below for the results!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issues highlighted by our compiler compatibility matrix testing for C++ compilers triaged a "Update expected results". This covers a bucket of issues where the expected results on a specific compiler differ from our expected results, but not in a semantically meaningful way.
These changes are grouped into three categories:
Change request type
.ql
,.qll
,.qls
or unit tests)Rules with added or modified queries
A14-7-2
- qcc, gcc, clangA15-1-5
- qcc, gcc, clangA18-0-3
- qcc, gcc, clangA26-5-1
- qcc, gcc, clangERR59-CPP
- qcc, gcc, clangM18-2-1
- qcc, gccM18-7-1
- qcc, gcc, clangM27-0-1
- qcc, gcc, clangMSC50-CPP
- qcc, gcc, clangRelease change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.