Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Finish dataflow refactor #12751

Merged
merged 13 commits into from
Apr 14, 2023
Merged

Java: Finish dataflow refactor #12751

merged 13 commits into from
Apr 14, 2023

Conversation

egregius313
Copy link
Contributor

No description provided.

@egregius313 egregius313 added the no-change-note-required This PR does not need a change note label Apr 3, 2023
@egregius313 egregius313 requested a review from a team as a code owner April 3, 2023 18:03
@github-actions github-actions bot added the Java label Apr 3, 2023
atorralba
atorralba reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, with a couple of comments.

java/ql/test/query-tests/security/CWE-798/semmle/tests/HardcodedCredentialsSourceCall.ql Outdated Show resolved Hide resolved
java/ql/lib/semmle/code/java/security/SensitiveResultReceiverQuery.qll Show resolved Hide resolved
@egregius313 egregius313 force-pushed the egregius313/dataflow-refactor-cleanup branch from 889a974 to 72907eb Compare April 10, 2023 15:41
@egregius313 egregius313 requested a review from atorralba April 11, 2023 16:08
atorralba
atorralba reviewed Apr 13, 2023
View reviewed changes
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more minor things.

java/ql/lib/semmle/code/java/security/SensitiveResultReceiverQuery.qll Outdated Show resolved Hide resolved
java/ql/lib/semmle/code/java/security/SensitiveResultReceiverQuery.qll Show resolved Hide resolved
@egregius313 egregius313 force-pushed the egregius313/dataflow-refactor-cleanup branch from 9c80814 to 0a26916 Compare April 14, 2023 03:06
@egregius313 egregius313 requested a review from atorralba April 14, 2023 03:09
@egregius313 egregius313 merged commit 38826c9 into github:main Apr 14, 2023
@owen-mc owen-mc mentioned this pull request Jun 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull left review comments

@atorralba atorralba atorralba approved these changes

Assignees
No one assigned
Labels
documentation Java no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egregius313 @atorralba @aschackmull