-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Refactor Test DataFlow configurations to new API #12812
Java: Refactor Test DataFlow configurations to new API #12812
Conversation
5103ef7
to
0c2a1bd
Compare
0c2a1bd
to
9cd6900
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a cursory review and it LGTM, plus tests passing is a good indication that nothing broke.
Having said that, at least some of the configurations used in query tests (namely Xss[Config|Flow]
and QueryInjectionFlow[Config]
) could be imported from the corresponding *Query.qll
files instead of replicating them in the test. Or are you waiting to finish the *Query.qll
refactor to make this change in one go?
@atorralba I've decided to move the XSS and SpringJDBC queries over, since their configurations are already in |
5d987ea
to
e6a2528
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Moves test cases under
java/ql/test
to the new dataflow api.