Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Refactor Test DataFlow configurations to new API #12812

Merged

Conversation

egregius313
Copy link
Contributor

Moves test cases under java/ql/test to the new dataflow api.

@egregius313 egregius313 added the no-change-note-required This PR does not need a change note label Apr 13, 2023
@egregius313 egregius313 force-pushed the egregius313/java/dataflow/refactor-tests branch from 5103ef7 to 0c2a1bd Compare April 14, 2023 02:10
@egregius313 egregius313 marked this pull request as ready for review April 14, 2023 02:48
@egregius313 egregius313 requested a review from a team as a code owner April 14, 2023 02:48
@egregius313 egregius313 force-pushed the egregius313/java/dataflow/refactor-tests branch 2 times, most recently from 0c2a1bd to 9cd6900 Compare April 14, 2023 14:42
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a cursory review and it LGTM, plus tests passing is a good indication that nothing broke.

Having said that, at least some of the configurations used in query tests (namely Xss[Config|Flow] and QueryInjectionFlow[Config]) could be imported from the corresponding *Query.qll files instead of replicating them in the test. Or are you waiting to finish the *Query.qll refactor to make this change in one go?

@egregius313
Copy link
Contributor Author

could be imported from the corresponding *Query.qll files instead of replicating them in the test. Or are you waiting to finish the *Query.qll refactor to make this change in one go?

@atorralba I've decided to move the XSS and SpringJDBC queries over, since their configurations are already in lib/. The XPath configuration is still defined in src/, so that one is better handled in the *Query.qll refactor imo.

@egregius313 egregius313 force-pushed the egregius313/java/dataflow/refactor-tests branch from 5d987ea to e6a2528 Compare April 18, 2023 03:48
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java Kotlin no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants