Go: Fix platform specific tests#12873
Merged
owen-mc merged 2 commits intogithub:mainfrom Apr 19, 2023
Merged
Conversation
These were introduced in github#12750 but the relevant tests that should have caught it weren't run.
smowton
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the expected test results introduced in #12750 are platform-specific. This PR excludes those functions from the tests. It also (horrifyingly) turns out that the results differ between Go 1.20.0 and Go 1.20.3, so this PR updates the tests to run on the latest patch version of Go 1.20.