Typescript full mode fixes #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some crashes in the 14 projects that started failing after TypeScript full mode became the default on LGTM.com this week.
Some issues that came from the TypeScript compiler itself:
getProperties()on the typetypeof globalThis | {}caused it to crash. I've worked around it by catching the exception.typeSignatureToStringon this type signature caused an out-of-memory error for some reason. I suspect this has something to do with the use ofinfertypes, so I've disabled type extraction inside conditional types (which are whereinfertypes are introduced).Lastly, we didn't handle
export=correctly when the right-hand side was an expression. I've fixed that.I'll run an evaluation as well.