Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Add models-as-data content for pointer content #13454

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Jun 14, 2023

This is based on #13453 and fixes the failing tests added in that PR.

@owen-mc owen-mc requested a review from a team as a code owner June 14, 2023 13:24
@github-actions github-actions bot added the Go label Jun 14, 2023
smowton
smowton previously approved these changes Jun 14, 2023
@owen-mc owen-mc force-pushed the go/add-mad-content-for-pointer-content branch from d9faee1 to 8b292fa Compare June 14, 2023 15:55
@owen-mc owen-mc changed the title Add models-as-data content for pointer content Go: Add models-as-data content for pointer content Jun 14, 2023
@michaelnebel
Copy link
Contributor

Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool with an extension to the MaD DSL for GO :-)

@@ -342,6 +342,8 @@ predicate parseContent(string component, DataFlow::Content content) {
component = "MapKey" and content instanceof DataFlow::MapKeyContent
or
component = "MapValue" and content instanceof DataFlow::MapValueContent
or
component = "Dereference" and content instanceof DataFlow::PointerContent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider updating the header comment in this file for input/output that it is now possible to use "Dereference" as a part of an access path.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Access paths weren't mentioned. I've copied what C# says about it and updated it to newer syntax without "of". I've taken the liberty of updating the C# one as well.

@owen-mc owen-mc added the no-change-note-required This PR does not need a change note label Jun 20, 2023
@owen-mc owen-mc force-pushed the go/add-mad-content-for-pointer-content branch from 8b292fa to 04ff89e Compare June 20, 2023 10:06
@owen-mc owen-mc requested a review from a team as a code owner June 20, 2023 10:06
@github-actions github-actions bot added the C# label Jun 20, 2023
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and thank you for the C# update as well 👍

@owen-mc owen-mc merged commit cdc1c2c into github:main Jun 20, 2023
@owen-mc owen-mc deleted the go/add-mad-content-for-pointer-content branch June 20, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Go no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants