Skip to content

C#: Fix assembly attribute extraction in standalone mode #14792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2023
Merged

C#: Fix assembly attribute extraction in standalone mode #14792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion csharp/extractor/Semmle.Extraction.CSharp/Populators/TypeContainerVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,10 @@ public override void VisitAttributeList(AttributeListSyntax node)
SyntaxKind.ModuleKeyword => Entities.AttributeKind.Module,
_ => throw new InternalError(node, "Unhandled global target")
};
foreach (var attribute in node.Attributes)
var attributes = node.Attributes;
for (var i = 0; i < attributes.Count; i++)
{
var attribute = attributes[i];
if (attributeLookup.Value(attribute) is AttributeData attributeData)
{
var ae = Entities.Attribute.Create(Cx, attributeData, outputAssembly, kind);
Expand Down
2 changes: 2 additions & 0 deletions csharp/ql/test/library-tests/standalone/assemblyattribute/attr.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
| standalone.cs:3:12:3:29 | [assembly: Attribute1(...)] |
| standalone.cs:9:2:9:11 | [Attribute1(...)] |
5 changes: 5 additions & 0 deletions csharp/ql/test/library-tests/standalone/assemblyattribute/attr.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import csharp

from Attribute a
where a.getType().getName() = "Attribute1Attribute"
select a
1 change: 1 addition & 0 deletions csharp/ql/test/library-tests/standalone/assemblyattribute/options
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
semmle-extractor-options: --standalone
12 changes: 12 additions & 0 deletions csharp/ql/test/library-tests/standalone/assemblyattribute/standalone.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
using System;

[assembly: global::Attribute1]

class Attribute1Attribute : Attribute
{
}

[Attribute1]
class A
{
}