Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
TNodeEx
newtype
fromDataFlowImpl.qll
intoDataFlowImplCommon.qll
(and makes itcached
). The purpose of doing this is to avoid an additionalnewtype
creation for all instantiations of the data flow library, and as witnessed by the DCA runs it has a very positive impact on memory/cache usage (and in general also a modest impact on timing).Before moving the
newtype
, the first commit removes the BooleanhasRead
column fromTNodeImplicitRead
, in order to the size of thenewtype
when later caching it. This commit then also adjusts the generatededges
relation by never revealing the implicit reads that happen at sinks.Commit-by-commit review is suggested.