Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Implement stdin models #17335

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Go: Implement stdin models #17335

wants to merge 5 commits into from

Conversation

egregius313
Copy link
Contributor

Adds source models for the stdin threat model.

These models are implemented in QL instead of MaD due to limitations in MaD:

  • MaD does not currently handle variable arguments as well as getAnImplicitVarargsArgument
  • MaD has a way to access fields on structs, but not variables in a package. (This is generally not that important, but it is necessary for modeling os.Stdin).

@egregius313
Implement stdin models
dcde139 
Unfortunately due to how variable and varargs work, these are better
done in QL
@egregius313 egregius313 requested a review from a team as a code owner August 29, 2024 18:24
@github-actions github-actions bot added the Go label Aug 29, 2024
owen-mc
owen-mc previously approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only trivial comments.

go/ql/lib/semmle/go/frameworks/stdlib/Os.qll Outdated Show resolved Hide resolved
go/ql/lib/change-notes/2024-08-29-add-stdin-threat-models.md Outdated Show resolved Hide resolved
@egregius313 @owen-mc
Remove unnecessary asExpr()
e6f66d6 
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com>
@egregius313 @owen-mc
Wording of change note
46c50b3 
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com>
@owen-mc
Copy link
Contributor

owen-mc commented Sep 4, 2024

Looks like my suggestion needs reformatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-mc owen-mc owen-mc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
documentation Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egregius313 @owen-mc