Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.23 fixups #17341

Open
wants to merge 36 commits into
base: mbg/go/1.23
Choose a base branch
from
Open

Go 1.23 fixups #17341

wants to merge 36 commits into from

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Aug 30, 2024

No description provided.

@smowton smowton requested review from a team as code owners August 30, 2024 13:38
@smowton
Extract struct field tags
774782c 
Previously we had structs with different trap labels (because the labels already included the tags, which make structs non-identical), but no way to distinguish them in QL.
@smowton
Look through aliases in hasOwnField
df13f89
@smowton
Expose whether functions are variadic in their pp() output
9409b0b
@smowton
Implement deep unaliasing, and use it in interface dispatch resolution
ac34546
@smowton
Transparent aliases: don't look through named types
02ea433
@smowton
Transparent aliases: don't write an invalid type to the @types table …
e61bb8d 
…on extracting an alias
@smowton
Distinguish types with and without explicit aliases in the type-label…
a037572 
… cache
@smowton
Fix Mongodb additional taint step
08c195d
@smowton
Don't repeat parts of extractType that populate tracking tables
7cde3df
@smowton
Fix flow through pointer types related by aliasing
b7fac65
@smowton
Fix missed case
7082005
@smowton
Improve efficiency of composite-type deep-unalias computation
eb1e6b1
@smowton
Make deep-unalias computation even more efficient using unpack routines
5e457e1
@smowton
Only extract transparent-alias versions of types when necessary
57e986a
@smowton
Fix struct deepUnaliasedType predicate
ab09340
@smowton
Implement deep-unalias for interface types
85ab444
@smowton
Fix TupleType's getDeepUnaliasedType, and make it efficient
5d10e36
@smowton
Amend upgrade and downgrade scripts to look through aliases
847e11d
@smowton
Interface types: distinguish otherwise-identical interfaces with non-…
f2a35d4 
…exported methods defined in different packages
@smowton
autoformat and tidy an unnecessary direct db relation use
ac39376
@smowton
Interface unaliasing: don't confuse the empty interface with the type…
1609aa5 
… 'comparable'
@smowton
Downgrades de-alising library: efficiency fixes
77321e6
@smowton
Fix
89abd53
@smowton
Port Types.qll fixes to the downgrade scripts, and fix a trivial Tupl…
4a1f412 
…eType deep-unalias bug
@smowton smowton removed the request for review from a team September 2, 2024 15:34
@smowton
Copy link
Contributor Author

smowton commented Sep 2, 2024

Positive DCA results: https://github.com/github/codeql-dca-main/issues/23447

Now running QA: https://github.com/github/codeql-qa-ops/issues/191

@criemen
Copy link
Collaborator

criemen commented Sep 3, 2024

Did you see that https://github.com/bazelbuild/rules_go/releases/tag/v0.50.0 was released? That way, we should be able to fully rely on upstream again.

@mbg
Copy link
Member

mbg commented Sep 3, 2024

@criemen note that the main PR for this is #17058 and this is just Chris' additions to it. The rules_go fix there was PR-ed in by @redsun82 a little while ago. I don't think anyone on our team keeps tabs on new releases of the Bazel libraries.

@criemen
Copy link
Collaborator

criemen commented Sep 3, 2024

Thanks, commented there instead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smowton @criemen @mbg