Add Expr, Stmt, Pat to schema.py #17390
Conversation
aibaars
force-pushed
the
aibaars/rust-experiment
branch
from
9e3cd27
to
eeaafcb
Compare
|
Looks amazing! 🎉 Having |
aibaars
force-pushed
the
aibaars/rust-experiment
branch
from
eeaafcb
to
679d81a
Compare
There was a problem hiding this comment.
Some small naming nits and one probable typo, and some questions from my side, but this looks great as a starting point, thanks!
We should not forget when we do start extracting things to add some code snippets as examples to class docstrings. That helps us along the way, the QL writer then, and if we don't do it from the start we risk never really catching up
rust/schema.py
Outdated
| # }, | ||
|
|
||
|
|
||
| class Async(Block): |
There was a problem hiding this comment.
would maybe AsyncBlock be more informative on the QL side?
| class Call(Expr): | ||
| callee: Expr | ||
| args: list[Expr] | ||
| is_assignee_expr: predicate |
There was a problem hiding this comment.
uh, this is making me curious 🙂
| # }, | ||
|
|
||
|
|
||
| class Yeet(Expr): |
There was a problem hiding this comment.
for the curious, this is an experimental feature that we're not probably going to really encounter https://doc.rust-lang.org/stable/unstable-book/language-features/yeet-expr.html
There was a problem hiding this comment.
Maybe we should just remove it for now? Given that it's highly experimental and placeholder syntax that is going to change in the future.
There was a problem hiding this comment.
Not sure. I could remove the class and translate yeet to MissingExpr in the extractor.
| class BinaryOp(Expr): | ||
| lhs: Expr | ||
| rhs: Expr | ||
| op: optional[string] |
There was a problem hiding this comment.
out of curiosity, do you know what does op: None mean?
There was a problem hiding this comment.
I have no idea, I am equally curious. Just haven't found the time to run an example expression through the pretty_print function.
This PR adds classes for expressions, statements, and patterns to the schema. The code is most auto-generated by co-pilot. The definitions of the HIR datatypes can be found at https://github.com/rust-lang/rust-analyzer/blob/master/crates/hir-def/src/hir.rs#L169-L300