Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: Re-introduce the original version of the many_defs_per_use IR test #17399

Merged
merged 1 commit into from
Sep 9, 2024
Merged

C++: Re-introduce the original version of the many_defs_per_use IR test #17399

merged 1 commit into from
Sep 9, 2024

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Sep 6, 2024

See: 28cff2e

@jketema jketema requested a review from a team as a code owner September 6, 2024 15:40
@github-actions github-actions bot added the C++ label Sep 6, 2024
geoffw0
geoffw0 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember this issue, and I'm glad we can revert to the original test now. The .expected changes are pretty long and appear trivial at a quick look???

👍

@jketema jketema merged commit 1250e72 into github:main Sep 9, 2024
10 checks passed
@jketema jketema deleted the simplify branch September 9, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jketema @geoffw0