C++: Merge the location tables #17581
Open
+17,464
−11,268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
force-pushed
the
loc-table-merge
branch
10 times, most recently
from
9299482 to
c05417a
Compare
jketema
added
the
depends on internal PR
jketema
force-pushed
the
loc-table-merge
branch
2 times, most recently
from
f6d5deb to
a8ce943
Compare
jketema
force-pushed
the
loc-table-merge
branch
2 times, most recently
from
ea8b00b to
52af6d5
Compare
IdrissRio
reviewed
Jun 27, 2025
| @@ -218,10 +218,10 @@ extractor_version( | |||
| string frontend_version: string ref | |||
| ) | |||
|
|
|||
| @location = @location_stmt | @location_expr | @location_default ; | |||
| @location = @location_default ; | |||
There was a problem hiding this comment.
Can location_default be removed?
There was a problem hiding this comment.
We need it, because xmllocations table uses it, and the xml tables are effectively shared across the dbschemes of different languages. There's one extractor for XML files, and it expects that part of the dbscheme to be identical for all languages. Renaming @location_default to @location wouldn't really affect things functionally, but will be slightly confusing if you work across languages.
An alternative would be to drop @location completely and call everything @location_default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See internal PR for details.
Pull Request checklist
All query authors
.qhelp. See the documentation in this repository.Internal query authors only
.ql,.qll, or.qhelpfiles. See the documentation (internal access required).