C#: Deprecate experimental queries.#17911
Merged
michaelnebel merged 3 commits intogithub:mainfrom Jan 21, 2025
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| isClassUnsafeXmlSerializerImplementation(c, m) and | ||
| message = | ||
| "Defining an serializable class $@ that has member $@ of a type that is derived from DataSet or DataTable types and may lead to a security problem. Please visit https://go.microsoft.com/fwlink/?linkid=2132227 for details." and | ||
| classMessage = c.toString() and |
Check warning
Code scanning / CodeQL
Using 'toString' in query logic Warning
| "Defining an serializable class $@ that has member $@ of a type that is derived from DataSet or DataTable types and may lead to a security problem. Please visit https://go.microsoft.com/fwlink/?linkid=2132227 for details." and | ||
| classMessage = c.toString() and | ||
| member = m and | ||
| memberMessage = m.toString() |
Check warning
Code scanning / CodeQL
Using 'toString' in query logic Warning
| FlowToDataSerializerConstructor::flow(source, sink) and | ||
| message = | ||
| "Unsafe type is used in data contract serializer. Make sure $@ comes from the trusted source." and | ||
| sourceMessage = source.toString() |
Check warning
Code scanning / CodeQL
Using 'toString' in query logic Warning
csharp/ql/src/experimental/Security Features/Serialization/XmlDeserializationWithDataSet.ql
Fixed
Show fixed
Hide fixed
| timeComparisonCall, selStatement) and | ||
| message = | ||
| "Possible TimeBomb logic triggered by an $@ that takes into account $@ from the $@ as part of the potential trigger." and | ||
| timeComparisonCallString = timeComparisonCall.toString() and |
Check warning
Code scanning / CodeQL
Using 'toString' in query logic Warning
Contributor
Author
|
DCA didn't report any performance degradations of changes to alerts. |
michaelnebel
force-pushed
the
csharp/deprecateexperimental
branch
from
8e6a849 to
9e86ef1
Compare
michaelnebel
force-pushed
the
csharp/deprecateexperimental
branch
from
9e86ef1 to
315279f
Compare
hvitved
approved these changes
Dec 2, 2024
michaelnebel
force-pushed
the
csharp/deprecateexperimental
branch
from
315279f to
9356295
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The experimental queries are being deprecated. Instead a copy of the queries have been added to the CodeQL-Community-Packs.