Java: add File.getName as a path injection sanitizer#18214
Merged
jcogs33 merged 2 commits intogithub:mainfrom Dec 11, 2024
Merged
Java: add File.getName as a path injection sanitizer#18214jcogs33 merged 2 commits intogithub:mainfrom
jcogs33 merged 2 commits intogithub:mainfrom
Conversation
1e0ef81 to
121780c
Compare
owen-mc
reviewed
Dec 5, 2024
Contributor
owen-mc
left a comment
There was a problem hiding this comment.
Looks good to me. Just needs a change note. You could use MRVA to find instances of the sanitizer to check that it's doing the right thing, given that it probably won't have that much effect on actual results.
Contributor
Author
|
Thanks for the review!
Yes, it's still in draft due to the change note and MRVA/DCA review. 🙂 |
Contributor
Author
|
MRVA/DCA alert changes look reasonable. |
owen-mc
approved these changes
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
java.io.File.getNameas a path injection sanitizer.Pull Request checklist
All query authors
Internal query authors only