Merged
Conversation
hvitved
force-pushed
the
ruby/dataflow-types
branch
from
4539ab3 to
9d66c04
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * | ||
| * the SSA definition for `c` is introduced by matching on `C`. | ||
| */ | ||
| predicate asModulePattern(Ssa::WriteDefinition def, Module m) { |
Check warning
Code scanning / CodeQL
Predicates starting with "get" or "as" should return a value Warning
hvitved
force-pushed
the
ruby/dataflow-types
branch
7 times, most recently
from
cc7c7dd to
6ffd2b6
Compare
hvitved
force-pushed
the
ruby/dataflow-types
branch
from
8996662 to
79cb62f
Compare
hvitved
force-pushed
the
ruby/dataflow-types
branch
from
79cb62f to
37212cc
Compare
aibaars
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #15118.
This PR implements tracking of types in data flow for Ruby, which may help reduce false-positive results when type incompatibility can be established. DCA looks good; performance is (mostly) maintained while we are able to eliminate some false positives.