Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Simplify more semmle-extractor-options #18350

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Dec 20, 2024

This will allow us to drop a number of special cases from the extractor.

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@github-actions github-actions bot added the C++ label Dec 20, 2024
@@ -1,4 +1,4 @@
// semmle-extractor-options: -Werror
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option is ignored by the extractor.

This will allow us to drop a number of special cases from the
extractor.
@jketema jketema marked this pull request as ready for review December 20, 2024 15:26
@jketema jketema requested a review from a team as a code owner December 20, 2024 15:26
@jketema jketema merged commit 659ec66 into github:main Dec 20, 2024
9 checks passed
@jketema jketema deleted the test-cleanup-2 branch December 20, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants