Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: Support concept id expressions #18366

Draft
wants to merge 5 commits into
base: jketema/template-parameters-4
Choose a base branch
from
Draft

C++: Support concept id expressions #18366

wants to merge 5 commits into from

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Dec 25, 2024

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Dec 25, 2024
@jketema jketema changed the base branch from main to jketema/template-parameters-4 December 25, 2024 10:29
@jketema jketema changed the title C++: Support concept id expression C++: Support concept id expressions Dec 25, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 25, 2024
View reviewed changes
cpp/ql/lib/semmle/code/cpp/Concept.qll
* If the concept id is a type constraint, then `getTemplateArgument(0)`
* will not yield a result.
*/
final Locatable getTemplateArgument(int index) {

Check warning

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for index, but the QLDoc mentions int
cpp/ql/lib/semmle/code/cpp/Concept.qll
* then `getTemplateArgumentKind(1)` yields `int`, and there is no result for
* `getTemplateArgumentKind(0)`.
*/
final Locatable getTemplateArgumentKind(int index) {

Check warning

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for index, but the QLDoc mentions int
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jketema