Rust: Change array element content type into a general collection element content type#18568
Merged
paldepind merged 3 commits intogithub:mainfrom Jan 24, 2025
Merged
Rust: Change array element content type into a general collection element content type#18568paldepind merged 3 commits intogithub:mainfrom
paldepind merged 3 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
hvitved
requested changes
Jan 23, 2025
| */ | ||
| final class ArrayElementContent extends Content, TArrayElement { | ||
| ArrayElementContent() { this = TArrayElement() } | ||
| final class CollectionContent extends Content, TArrayElement { |
Contributor
There was a problem hiding this comment.
TArrayElement should be renamed to TElementContent as well. This will also reveal that the MaD token "ArrayElement" needs to be changed in FlowSummaryImpl.qll. And once that is done, the QL doc in ModelsAsData.qll needs to be updated, as well as a few tests.
geoffw0
previously approved these changes
Jan 23, 2025
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
LGTM. I have a local branch that is waiting for this, thanks for getting it done!
hvitved
requested changes
Jan 23, 2025
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
One last thing, otherwise LGTM.
hvitved
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new
CollectionContentis similar to the same content type in C/C++ and Swift.