Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: Support mixed typedefs and usings #18606

Merged
merged 3 commits into from
Jan 30, 2025
Merged

C++: Support mixed typedefs and usings #18606

merged 3 commits into from
Jan 30, 2025

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Jan 28, 2025

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Jan 28, 2025
@Copilot Copilot bot review requested due to automatic review settings January 28, 2025 09:27
@jketema jketema requested a review from a team as a code owner January 28, 2025 09:27
Copilot
Copilot AI reviewed Jan 28, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
@github-actions github-actions bot added the C++ label Jan 28, 2025
@jketema jketema added the no-change-note-required This PR does not need a change note label Jan 28, 2025
@jketema jketema merged commit 8f25dbf into github:main Jan 30, 2025
11 of 16 checks passed
@jketema jketema deleted the typeref branch January 30, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@calumgrant calumgrant calumgrant approved these changes

Assignees
No one assigned
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jketema @calumgrant